Allow to read logs for public repo in ws #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floatdrop
changed the title
|
We should probably only log when |
|
Done. |
| log.Printf("WS: No read access for repository %s\n", work.Repo.Name) | ||
| } | ||
| if work.Repo.Private == true && role.Read == false { | ||
| log.Printf("WS: No read access for repository %s\n", work.Repo.Name) |
There was a problem hiding this comment.
actually this login should be removed also, since it is expected behavior. This is a global event feed. This means if 1000 users are logged-in to Drone, 1000 users will get this message. If only 1 user has access, we would see 999 log entries.
There was a problem hiding this comment.
@bradrydzewski make sens. Removed logging, but build is failing on fetching deps.
bradrydzewski
added a commit
that referenced
this pull request
Feb 21, 2015
Allow to read logs for public repo in ws
bot2-harness
pushed a commit
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #882. If repository is public, but no rows in
permstable is met - logs should still be accessable.