Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LANG and LANGUAGE from environment #880

Merged
merged 1 commit into from
Feb 18, 2015

Conversation

floatdrop
Copy link

LANG and LANGUAGE should be set by container image, not by drone.

@bradrydzewski
Copy link

Thanks for this. One minor request. Can we keep the lang and language for the default drone/images? https://github.com/floatdrop/drone/blob/master/shared/build/build.go#L450

    switch {
    case strings.HasPrefix(b.Build.Image, "bradrydzewski/"),
        strings.HasPrefix(b.Build.Image, "drone/"):
+       f.WriteEnv("LANG", "en_US.UTF-8")       
+       f.WriteEnv("LANGUAGE", "en_US:en")
        dockerfile.WriteUser("ubuntu")
        dockerfile.WriteEnv("LOGNAME", "ubuntu")
        dockerfile.WriteEnv("HOME", "/home/ubuntu")
        dockerfile.WriteRun("sudo chown -R ubuntu:ubuntu /var/cache/drone")
        dockerfile.WriteRun("sudo chown -R ubuntu:ubuntu /usr/local/bin/drone")
    default:

This will keep things backward compatible for now when using the official Drone images, but will prevent them from being set in custom images.

bradrydzewski added a commit that referenced this pull request Feb 18, 2015
Remove LANG and LANGUAGE from environment
@bradrydzewski bradrydzewski merged commit aca0029 into harness:master Feb 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants