Getting github orgs more than 30 #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have also found https://github.com/stvp/flowdock is missing... Is there any fork? |
| if len(orgs) == 0 || err != nil { | ||
| break | ||
| } | ||
| for _, v := range orgs { |
There was a problem hiding this comment.
instead of looping, you can do something like this:
allorgs = append(allorgs, orgs...)
@udzura I have a local copy. I'll vendor the dependency and push and update shortly |
|
ok, just merged #848 to fix the flowdock issue! |
|
@bradrydzewski Hi, test passed again. Thank you for review! |
|
cool, much thanks for the patch! |
bradrydzewski
added a commit
that referenced
this pull request
Jan 26, 2015
Getting github orgs more than 30
bot2-harness
pushed a commit
that referenced
this pull request
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, dear team
github.com (or GH Enterprise) API have a default per_page limit to
30. SoGetOrgsfunction could not get organizations after the 31st one.I have added the pagination loop and found this fixed.