Fix services behaviour when docker net is host #841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bradrydzewski looks like CI may be having some issues.... |
|
@dave-tucker I just pushed a new yaml that runs |
| // setup configuration | ||
| config := Config{Image: image} | ||
| host := HostConfig{} | ||
| host.NetworkMode = "host" |
There was a problem hiding this comment.
I'm definitely not an expert in Docker networking, but their documentation indicates this should be used with caution. What security implications are there? Could someone issue a pull request that alters my yaml and do bad things to my test.drone.io server?
There was a problem hiding this comment.
When using --net=host all ports are made available to the host system and an application can see/use then hosts network adapters.
Therefore we only launch the services this way when:
- This is not a PR
- The user has this in their YAML:
docker:
net: host
When the image runs with `--net host`, docker links will not work. This commit checks to see if `--net host` has been set, and if so creates the services in `--net host` also. Fixes harness#839 Signed-off-by: Dave Tucker <[email protected]>
|
Closing this one due to lack of activity |
bot2-harness
pushed a commit
that referenced
this pull request
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the image runs with
--net host, docker links will not work.This commit checks to see if
--net hosthas been set, and if socreates the services in
--net hostalso.Fixes #839
Signed-off-by: Dave Tucker [email protected]