Remove explicit go get for goblin package
#796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, we can definitely remove the reference to goblin. We will still need to |
|
we might be able to do something like this: the rice repository would get cloned during the first |
|
Ah, my bad - I saw the import here but that wouldn't include the I think the following would do the trick: go get github.com/GeertJohan/go.rice/rice
go get -t -v ./... |
The goblin package will be pulled in by the `go get` invocation on the following line as it's references by imports, so there's no need to list it separately.
mattbostock
force-pushed
the
tidy_dependencies
branch
from
8201e40
to
3cb015a
Compare
|
I've rebased to fix. |
bradrydzewski
added a commit
that referenced
this pull request
Jan 11, 2015
Remove explicit `go get` for rice and goblin pkgs
mattbostock
changed the title
go get for rice and goblin pkgsgo get for goblin package
bot-harness
pushed a commit
that referenced
this pull request
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of these packages will be pulled in by the
go getinvocation on the following line as they are references by imports, so there's no need to list them separately.