Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin NPM packages using npm shrinkwrap for repeatable builds #794

Closed
wants to merge 4 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Run npm install each time make deps is invoked
The NPM modules, used primarily to render the Less files into CSS, don't
seem any less important than other build dependencies so I don't see the
harm in running this every time `make deps` is invoked.
  • Loading branch information
mattbostock committed Jan 11, 2015
commit d161092b7a99c8167512b7d9fcfb40c8e1c351dd
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ SHA := $(shell git rev-parse --short HEAD)
all: build

deps:
# which npm && npm install
npm install
go get github.com/GeertJohan/go.rice/rice
go get github.com/franela/goblin
go get -t -v ./...
Expand Down