Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Mercurial repositories (on Bitbucket at least) #785

Closed
wants to merge 15 commits into from

Conversation

faide
Copy link

@faide faide commented Jan 6, 2015

I am open to comments and suggestions since I know the way I did it is suboptimal ie: if isGit returns False defaults to mercurial... which makes it impossible at the moment to add more VCSs

@cedk
Copy link

cedk commented Jan 10, 2015

I think Repo struct could have a Scm attribute which will be filled by remotes instead of guessing.

@cedk
Copy link

cedk commented Jan 11, 2015

I created #793 that adds and uses a scm on repo.

@bradrydzewski
Copy link

I've also been kicking around the idea of letting the plugin define the shell commands (ie git clone). We could then add a plugin for almost any service, using any scm. We could even add a plugin for something like Dropbox (not that we would want to).

@cedk
Copy link

cedk commented Jan 11, 2015

I don't think it is a so good idea to have plugin defines the shell commands because we will loose some factoring of the code. There are many hosting services but not so many SCM's. Also as if you add a know plugin it should anyway modify the code, you can also modify the build of repo.

@bradrydzewski
Copy link

@cedk one thing to consider is that the method for cloning and merging pull requests (so that they can be tested) differs depending on which hosting solution is used.

@cedk
Copy link

cedk commented Jan 11, 2015

@bradrydzewski until now with the supported hosting, there is no differences. But I guess there could be some methods defined on Remote to retrieve the SCM commands or the some kind of flavor.
But could you take a look at #793 if it is a good start?

@kzaitsev kzaitsev mentioned this pull request Jan 18, 2015
bot-harness pushed a commit that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants