Automatically detect ENV variables #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzaitsev
force-pushed
the
detect_envs
branch
from
7deb991
to
b07cd78
Compare
| } else { | ||
| return "" | ||
| } | ||
| } |
There was a problem hiding this comment.
this could be simplified to the following:
func getHost() string {
return os.Getenv("DOCKER_HOST")
}
since Getenv will return an empty string if the environment variable doesn't exist :)
kzaitsev
force-pushed
the
detect_envs
branch
from
b07cd78
to
5b07ef5
Compare
|
@bradrydzewski done |
|
thanks for this! |
bradrydzewski
added a commit
that referenced
this pull request
Dec 27, 2014
Automatically detect ENV variables
bot-harness
pushed a commit
that referenced
this pull request
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this MR adds support for boot2docker