Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify settingsStmt to make migrations easier #76

Closed
wants to merge 1 commit into from
Closed

Simplify settingsStmt to make migrations easier #76

wants to merge 1 commit into from

Conversation

floatdrop
Copy link

There is no need to explicit enumeration of fields names in select query.

@bradrydzewski
Copy link

I actually got migrations working, for now, like this:
https://github.com/drone/drone/blob/master/pkg/database/schema/schema.go#L199

@floatdrop floatdrop deleted the settingsstmt-simplification branch February 16, 2014 05:18
@floatdrop floatdrop restored the settingsstmt-simplification branch February 16, 2014 05:43
@floatdrop
Copy link
Author

But still, why should we bother about columns names in this statement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants