Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move env variables outsude docker build #PR2 #754

Merged
merged 1 commit into from
Dec 13, 2014

Conversation

kzaitsev
Copy link

bradrydzewski added a commit that referenced this pull request Dec 13, 2014
Move env variables outsude docker build #PR2
@bradrydzewski bradrydzewski merged commit fc881ba into harness:master Dec 13, 2014
@shawnzhu
Copy link

@Bugagazavr do you think it's a good idea to move environment variables into container configuration? so that all commands in build scripts (including git clone) can benefit from this. see https://github.com/drone/drone/blob/master/shared/build/build.go#L317

@kzaitsev
Copy link
Author

@shawnzhu Conversely, the configuration does not occur at the level of the container. At script.

@shawnzhu
Copy link

@Bugagazavr those injected environment variables during container creation will be available within container just like those exported ones in script. my point is removing export command which can be done via script stanza in .drone.yml in anyway.

@kzaitsev
Copy link
Author

@shawnzhu in the future, we will delete building container scenario ( https://github.com/drone/drone/blob/master/shared/build/build.go#L427-L465 ), and then we will create container from image ( any image ). Maybe this will be chnged, it is an intermediate option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants