Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Enterprise Support #75

Merged
merged 9 commits into from
Feb 18, 2014
Merged

GitHub Enterprise Support #75

merged 9 commits into from
Feb 18, 2014

Conversation

floatdrop
Copy link

This is reopen pull-request from #23

@floatdrop floatdrop mentioned this pull request Feb 14, 2014
9 tasks
@suguru
Copy link

suguru commented Feb 17, 2014

Hello, I have tested this pull request and some problems in our environment.

  • Our GHE is private mode. Any public repositories requires deploy keys to be cloned. Since drone use git protocol to clone public repositories, we should modify code to set private to true always.
  • Our GHE is running in local network and use http protocol. It would be perfect if I can select http or https.

@floatdrop
Copy link
Author

I'm not quite get first issue, but second is easy to fix. Could you provide more information about private option or links to information about it?

@suguru
Copy link

suguru commented Feb 17, 2014

I found Private Mode in privacy settings which located in mangement console.

screenshot 2014-02-17 18 59 16

@floatdrop
Copy link
Author

I think this is separate issue from GitHub enterprise integration. This will affect this issue as well.

bradrydzewski added a commit that referenced this pull request Feb 18, 2014
@bradrydzewski bradrydzewski merged commit 85e60e4 into harness:master Feb 18, 2014
@gondoi gondoi mentioned this pull request Feb 21, 2014
johannesHarness pushed a commit that referenced this pull request Sep 26, 2023
johannesHarness pushed a commit that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants