Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add activity feed endpoint #693

Merged
merged 2 commits into from
Nov 11, 2014
Merged

Add activity feed endpoint #693

merged 2 commits into from
Nov 11, 2014

Conversation

scottferg
Copy link

@bradrydzewski I know there's a push for minimalism on the Drone side but I don't see enough flexibility in the existing /api/user/feed endpoint to support what drone-wall (and really any ancillary Drone reporting tool) requires to accurately monitor activity of the server.

The issue with using /api/user/feed is this:
The endpoint returns only the latest status of each project. If a single build is occurring on a specific project, the results are sufficient. If a second build (i.e. an open pull request) occurs on that same project while the other build is running, it's unable to be reported to something like drone-wall. The perceived activity is that there is only the one build occurring, and no pull requests are open. This results in builds being lost from the wall record. We also have a fancy sign that lights up red/yellow/green depending on overall build statuses, and it also breaks that ;)

I mentioned the need for this here: drone/drone-wall#21

What this CL adds is just a more liberal /api/user/activity endpoint which provides a larger and ungrouped version of /api/user/feed. It shows all activity occurring within that user's visible projects and permits better tracking of the activity for things like drone-wall. We've been using this change internally for a week and have had very smooth operation on the wall and Drone v0.3.

Thoughts?

@bradrydzewski
Copy link

@scottferg agreed, the /api/user/feed endpoint is not very useful and is very specific to the Drone dashboard screen. In fact, having used the Drone dashboard screen for a few weeks we are probably going to change it and /api/user/activity is what we'll need.

We probably will end up replacing /api/user/feed with the /api/user/activity query, just as a heads up

bradrydzewski added a commit that referenced this pull request Nov 11, 2014
Add activity feed endpoint
@bradrydzewski bradrydzewski merged commit b33db29 into harness:master Nov 11, 2014
@scottferg
Copy link
Author

Sounds good, thanks!

bot-harness pushed a commit that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants