Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bradrydzewski I know there's a push for minimalism on the Drone side but I don't see enough flexibility in the existing
/api/user/feed
endpoint to support what drone-wall (and really any ancillary Drone reporting tool) requires to accurately monitor activity of the server.The issue with using
/api/user/feed
is this:The endpoint returns only the latest status of each project. If a single build is occurring on a specific project, the results are sufficient. If a second build (i.e. an open pull request) occurs on that same project while the other build is running, it's unable to be reported to something like drone-wall. The perceived activity is that there is only the one build occurring, and no pull requests are open. This results in builds being lost from the wall record. We also have a fancy sign that lights up red/yellow/green depending on overall build statuses, and it also breaks that ;)
I mentioned the need for this here: drone/drone-wall#21
What this CL adds is just a more liberal
/api/user/activity
endpoint which provides a larger and ungrouped version of/api/user/feed
. It shows all activity occurring within that user's visible projects and permits better tracking of the activity for things like drone-wall. We've been using this change internally for a week and have had very smooth operation on the wall and Drone v0.3.Thoughts?