Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject params into .drone.yml. #68

Merged
merged 1 commit into from
Feb 14, 2014
Merged

Inject params into .drone.yml. #68

merged 1 commit into from
Feb 14, 2014

Conversation

yosssi
Copy link

@yosssi yosssi commented Feb 13, 2014

Inject params into .drone.yml.
A related issue may be #25.

@bradrydzewski
Copy link

I like this patch! Do you think we could use mustache templates to inject the data?
https://github.com/hoisie/mustache

The syntax would be exactly the same {{ value }}, but using mustache could give us more flexibility.

@afex
Copy link

afex commented Feb 13, 2014

does this maintain compatibility with running builds directly via the drone command? is it a design goal for drone that .drone.yml files be portable for either use?

@bradrydzewski
Copy link

good point. maybe we inject local environment variables into the .drone.yml when running from the client? So I could do something like this:

AWS_KEY=xxxx AWS_SECRET=yyyy drone build

@bradrydzewski
Copy link

I'm going to go ahead and merge this since the syntax won't change if / when we support mustanche. I'll also think more about how this impacts drone-cli, but I don't want to hold this up in the mean time.

bradrydzewski added a commit that referenced this pull request Feb 14, 2014
Inject params into .drone.yml.
@bradrydzewski bradrydzewski merged commit aac473d into harness:master Feb 14, 2014
@yosssi
Copy link
Author

yosssi commented Feb 14, 2014

@afex @bradrydzewski
Thanks for your comments!
I'm now just fixing this function to use mustanche and drone-cli.
When I'll finish it, I'll send another PR.

@yosssi yosssi deleted the params-injection branch February 14, 2014 03:54
johannesHarness pushed a commit that referenced this pull request Sep 26, 2023
…#68)

* Implement file path edit input

* Implement file path edit input - cont

* Prototype for Commit modal

* Add routingId to support Harness gateway
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants