Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open invitation setting #67

Merged
merged 3 commits into from
Feb 16, 2014
Merged

Open invitation setting #67

merged 3 commits into from
Feb 16, 2014

Conversation

floatdrop
Copy link

Implementation of #64 issue:

2014-02-13 20-33-49 login drone io

Todo:

  • Fix html in templates
  • Add migration script for open_invitation setting in database

@bradrydzewski
Copy link

a couple of things

on the invitation form, where you enter the email, you can use <input class="only-child" to get the styling right :)

second, I added a db migration package, but haven't hooked it up yet. It would be interesting if you could invoke from here:
https://github.com/drone/drone/blob/master/cmd/droned/drone.go#L57

third, any ideas on how to unit test migrations? :)

@floatdrop
Copy link
Author

I will look into migrations today in different branch.

Thank you for the hints!

@bradrydzewski
Copy link

one minor comment here. The first time a user launches Drone, the Settings will not exist in the database, and will cause a panic:
https://github.com/floatdrop/drone/blob/6937b7b21e91b092ace26aeba8c17ca720f83160/pkg/handler/app.go#L50

maybe we should use

settings, _ := database.GetSettings()

and just make sure in the template we check for a nil settings?

@bradrydzewski
Copy link

maybe something like:

settings, err := database.GetSettings()
if err != nil {
    http.Redirect(w, r, "/install", http.StatusSeeOther)
}

what do you think?

bradrydzewski added a commit that referenced this pull request Feb 16, 2014
@bradrydzewski bradrydzewski merged commit 828cb84 into harness:master Feb 16, 2014
@bradrydzewski
Copy link

I'll go ahead and fix the potential panic issue right now. Thanks for taking it this far :)

@floatdrop
Copy link
Author

Thank you! I thought this commit will fix panic, but may be I miss something.

@floatdrop floatdrop deleted the open-invitations branch February 16, 2014 05:17
@bradrydzewski
Copy link

yes, you are right. your commit did fix it :)
thanks again!

johannesHarness added a commit that referenced this pull request Sep 26, 2023
This change is fixing our docker file which is used to build our harness code image used for PR deployments.
Furthermore, the change contains some logging improvements that were added along the way of setting up the PR environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants