Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verbose user repo feed #650

Merged
merged 3 commits into from
Oct 30, 2014
Merged

Add verbose user repo feed #650

merged 3 commits into from
Oct 30, 2014

Conversation

scottferg
Copy link

@bradrydzewski This is the only necessary piece for getting the refreshed drone-wall up to speed on 0.3. @Tathanen is working on getting that side refactored so we can push it out.

I'm open to suggestions on the design since this is a little hamfisted. We basically just need to get the /api/user/feed but also including Pending and Started builds. I've done this with an additional /api/user/feed/verbose endpoint that also extends the result limit to 20. We do a ton of build traffic at Vokal so the fatter response is something we've found to be necessary.

Indirectly fixes drone/drone-wall#10

@bradrydzewski
Copy link

the reason /api/user/feed doesn't include Pending or Started is because I didn't have time (yet) to hook the websocket up to the dashboard page in Angular. I definitely want to. I'm thinking we should alter /api/user/feed to include pending and started builds, and I can work on getting the websocket hooked up

@scottferg
Copy link
Author

Sounds good to me. What about a query string option to pull more than 5
repos (up to a set maximum)? Something like /api/user/feed?limit=10

On Wed, Oct 29, 2014, 11:53 PM Brad Rydzewski [email protected]
wrote:

the reason /api/user/feed doesn't include Pending or Started is because I
didn't have time (yet) to hook the websocket up to the dashboard page in
Angular. I'm thinking we should alter /api/user/feed to include pending
and started builds, and I can work on getting the websocket hooked up


Reply to this email directly or view it on GitHub
#650 (comment).

@kzaitsev
Copy link

What about offset?

@scottferg
Copy link
Author

Offset might work, yeah. The goal here is that for the initial launch the build wall should grab many repos. After the initial load only grabbing 5-10 is sufficient (at least for our uses).

bradrydzewski added a commit that referenced this pull request Oct 30, 2014
Add verbose user repo feed
@bradrydzewski bradrydzewski merged commit b93b244 into harness:master Oct 30, 2014
bot-harness pushed a commit that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow MySQL/MariaDB connections
3 participants