Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add worker-net parameter in configs #588

Closed
wants to merge 1 commit into from
Closed

Add worker-net parameter in configs #588

wants to merge 1 commit into from

Conversation

floatdrop
Copy link

This would give a way to change NetworkMode in case of IPv6-only hosts to host mode (cont. of #573).

@floatdrop
Copy link
Author

Any news on this?

@bradrydzewski
Copy link

Hey, sorry I didn't provide feedback sooner. Some thoughts below:

  • net should be configured on a per-repository basis, in the yaml, instead of globally
  • net should require a repository to have the privileged flag for security reasons
  • net should be ignored when building pull requests from public repositories for security reasons

For example, it is possible that docker (drone.docker.io) could have private repositories where they want to use --host=net. However, they could have public repositories where they don't want --host=net by default. This is especially true for public repositories and pull requests, where someone could issue a malicious PR that exploits access to the host machines network.

Eventually I would like the .drone.yml to look like this:

docker:
  net: host
  username: foo
  password: bar # for download private images
  privileged: true
  ...

I also eventually want to change the Repo.Privileged to Repo.Trusted. If Repo.Trusted == false the build will ignore the --net and --privileged parameters in the .drone.yml

@floatdrop
Copy link
Author

Sorry for closing previous PR too soon, I restored it - #588 (It has fix for privileged builds)

@floatdrop floatdrop deleted the config-worker-net branch December 24, 2014 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants