Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update worker nodes configuration example #579

Closed
wants to merge 1 commit into from
Closed

Update worker nodes configuration example #579

wants to merge 1 commit into from

Conversation

floatdrop
Copy link

I got strange error, when used nodes notation with [ and ] - I don't remember exactly, but it was something like this:

Can't connect to [
"tcp:https://

Instead I wrote in drone.toml in same way as in environment variable and it worked.

@solarfly73
Copy link

I also ran into this under CentOS7. However, that won't solve the problem of needing to specify multiple workers in the future.

@floatdrop
Copy link
Author

@solarfly73 doesn't placing them in one string (joined by ,) solves this for you?

@bradrydzewski
Copy link

This is actually a bug with the github.com/drone/config library which is not correctly parsing the string array from the toml file (the ENV parsing works fine).

I'm working on a quick patch that will resolve this issue at the library level, so that we can use the toml array syntax.

@solarfly73 we also have endpoints exposed that allow creating and removing workers on the fly, which I believe is what you are referring to. This hasn't been thoroughly tested, however, it is an important piece of functionality that will be available

work.Get("/api/workers", handler.GetWorkers)
work.Post("/api/workers", handler.PostWorker)
work.Delete("/api/workers", handler.DelWorker)

@floatdrop
Copy link
Author

@bradrydzewski this would be very useful for admin ui!

I close this one in favor to https://github.com/drone/config/issues/1

@floatdrop floatdrop closed this Oct 16, 2014
@floatdrop floatdrop deleted the nodes-configuration-fix branch October 16, 2014 18:04
johannesHarness pushed a commit that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants