Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3, Forming right redirect url for enterprise #407

Merged
merged 1 commit into from
Aug 3, 2014
Merged

0.3, Forming right redirect url for enterprise #407

merged 1 commit into from
Aug 3, 2014

Conversation

floatdrop
Copy link

This fixes redirect loop for github enterprise users.

But I still got Error retrieving currently authenticated GitHub user. Unauthorized error.

This fixes redirect loop for github enterprise users.

But I still got `Error retrieving currently authenticated GitHub user. Unauthorized` error.
@bradrydzewski
Copy link

cool, thanks. I think I know why you are getting the error. When we create a client, we aren't setting client.ApiUrl, so it is defaulting to https://api.github.com. I'll fix that shortly

bradrydzewski added a commit that referenced this pull request Aug 3, 2014
0.3, Forming right redirect url for enterprise
@bradrydzewski bradrydzewski merged commit 30767bd into harness:exp Aug 3, 2014
@bradrydzewski
Copy link

ok, just pushed a change a few minutes ago to set client.ApiUrl. I've verified it works with regular git, so hopefully this will fix the error message you are receiving.

@floatdrop floatdrop deleted the patch-1 branch August 3, 2014 17:44
@floatdrop
Copy link
Author

Yep, got it working with enterprise github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants