Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Helm kubernetes Deployment #3417

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

alexohneander
Copy link
Contributor

Added helm deployment so you can quickly deploy it to your Kubernetes cluster.

The deployment consists of:

  • Service
  • Deployment
  • PVC
  • Ingress
  • ServiceAccount

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2023

CLA assistant check
All committers have signed the CLA.

@alexohneander
Copy link
Contributor Author

@willzhang @arya-harness @abhinav-harness
Accidentally closed the pull request during the last commit and could not reopen it.
It is the same request as #3397 with the additional env vars.

@willzhang
Copy link

willzhang commented Oct 20, 2023

I found that the Docker Dind section has been deleted. Is this not needed, or is there any other solution?

docker:
  enabled: true
  image: docker:24.0.3-dind
  resources: {}
    # limits:
    #   cpu: 100m
    #   memory: 128Mi
    # requests:
    #   cpu: 100m
    #   memory: 128Mi

or can we mount host docker.sock or containerd.sock ? Uncertain whether gitness supports containerd

host:
  docker:
    sock: /var/run/docker.sock
  containerd:
    sock: /var/run/containerd/containerd.sock
  crio:
    sock: var/run/crio/crio.sock
volumes:

Perhaps in the k8s environment, gigness directly communicates with the k8s API and runs jobs by creating multiple worke pods?

or use drone-runner https://github.com/drone-runners/drone-runner-kube

@bradrydzewski
Copy link

bradrydzewski commented Oct 20, 2023

thanks @alexohneander for the contribution!

@willzhang good point, we would want a docker:dind container added for pipeline execution, similar to what we have in the official Drone help chart. See https://github.com/drone/charts/blob/master/charts/drone-runner-docker/templates/deployment.yaml#L40

adding @jimsheldon as a reviewer (he is the creator of the Drone chart)

charts/gitness/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/gitness/values.yaml Outdated Show resolved Hide resolved
@alexohneander
Copy link
Contributor Author

@willzhang @bradrydzewski I made a mistake yesterday. We still need the dind and that definitely has to go back in. I'll adjust it.

Copy link

@willzhang willzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

@alexohneander
Copy link
Contributor Author

Is there anything missing or can I tweak, I would love to do that. 😃

@hitesharinga hitesharinga merged commit 0128df0 into harness:main Nov 8, 2023
1 of 2 checks passed
@Lite5h4dow
Copy link

Lite5h4dow commented May 11, 2024

there is no index.yaml file for using these templates as a helm chart.
opened issue: #3512 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants