Add web UI for adding self-hosted git repositories #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is a good start! however we'll also need code for the post-commit hook, a strategy to retrieve the .drone.yml file prior to executing a build, the commit details (sha, branch, author, message). See my comment on #10 on the different things we'll need to add. adding generic git support is, in my opinion, the most difficult feature let's keep discussing this in #10 to make sure we get the design right. I want to get as much community input and eyes on this as possible. |
johannesHarness
added a commit
that referenced
this pull request
Sep 26, 2023
johannesHarness
pushed a commit
that referenced
this pull request
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a web UI for adding self-hosted git repositories (see issue #10). This pull request is only a partial solution. Things that I haven't implemented yet:
This pull request depends on pull request #33.