Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Remove internal reference #3377

Merged
merged 3 commits into from
Sep 23, 2023
Merged

Conversation

johannesHarness
Copy link
Collaborator

@johannesHarness johannesHarness commented Sep 23, 2023

It seems that we missed removing one of the harness internal references in the project, which is causing build issues (make build failed on mac).

This PR removes said reference, as well as the setup for private references in the Dockerfile.

Testing

  • Ensured docker build succeeds without access to any private repo (docker build --no-cache .)
  • Ran docker image and ensured default "hello-worl" pipeline runs

@johannesHarness johannesHarness changed the title [MISC] Remove internal reference [BUILD] Remove internal reference Sep 23, 2023
@johannesHarness johannesHarness merged commit 6b533ad into master Sep 23, 2023
1 check passed
@johannesHarness johannesHarness deleted the jobatzil/fix/gorbac branch September 23, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant