Allow to override default env variables with .env file #3338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
godotenv.Load
method does not overload the ENV variable if it is already present. This is a problem if you want to use--env-file
to provide any settings with default values in Dockerfile. This means, that it's not possible to setDRONE_DATABASE_SECRET
within .env file (trying to achieve the technique described here).In the case of deploying the Drone, I'm sure that using
godotenv.Overload
is preferable, because this allows to keep the database password private with docker secrets.My current workaround is using
entrypoint
to unset env variables: