(bugfix) add build params to Memoize cache key

[andrii-kasparevych]

This PR fixes the problem described here in details.
In short, when caching the Starlark/JSONNET conversion results, the build parameters are ignored which is harmful when the parameters are used for pipeline generation.

[bradrydzewski]

@andrii-kasparevych golang map iteration order is random which would result in different cache keys.

When iterating over a map with a range loop, the iteration order is not specified and is not guaranteed to be the same from one iteration to the next. If you require a stable iteration order you must maintain a separate data structure that specifies that order. From go.dev/blog/maps.

This could be solved by sorting to ensure deterministic ordering (snippet below, found on stackoverflow, needs testing). Alternatively you could set the DRONE_CONVERT_PLUGIN_CACHE_SIZE to 0 which disables caching. Generally speaking there should be no problem disabling caching unless you are executing 1000+ pipelines per hour.

func mapToHash(m map[string]string) string {
	keys := make([]string, len(m))
	h := sha256.New()
	i := 0
	for k := range m {
		keys[i] = k
		i++
	}
	sort.Strings(keys)
	for _, k := range keys {
		ioutil.WriteString(h, k)
		ioutil.WriteString(h, m[k])
	}

	return fmt.Sprintf("%x", h.Sum(nil))
}

[andrii-kasparevych]

@bradrydzewski thanks for the hint. I think I have confused the 2 memoise.go files in different places: here and here.

I will try disabling the caching and see if that does the trick

[andrii-kasparevych]

Disabling the caching worked for us, I will close the PR then.