Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DRON-392) cascade deletes on purge #3243

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Conversation

tphoney
Copy link

@tphoney tphoney commented Jul 28, 2022

Commit Checklist

Thank you for creating a pull request! To help us review / merge this can you make sure that your PR adheres as much as possible to the following.

The Basics

  • Commit is a single logical unit of work, only use multiple commits if doing different tasks
  • Commit does not include commented out code or unneeded files
  • rebase of main branch

The Content

  • Must include testing for bug or feature
  • Must include appropriate documentation changes if it is introducing a new feature or changing existing functionality
  • Must pass existing test suites

The Commit Message

  • Short meaningful description (ex: remove deprecated steps)
  • Uses the imperative, present tense: "change", not "changed" or "changes"
  • Includes motivation for the change, and contrasts its implementation with the previous behavior

The Pull Request

  • What is the reason for this change
  • Example usage of the failure for a bug, or configuration and expected output for a feature
  • Steps to test the change

@tphoney tphoney added the bug label Jul 28, 2022
core/stage.go Outdated Show resolved Hide resolved
Copy link

@bradrydzewski bradrydzewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion to encapsulate cascading purges in the Build purge function.

@tphoney tphoney force-pushed the DRON-392 branch 3 times, most recently from e37414e to 5f6f82d Compare July 28, 2022 17:01
@tphoney tphoney merged commit 730425f into harness:master Sep 8, 2022
@kosssi
Copy link

kosssi commented Oct 3, 2022

Why you don't respect your own rules? I thinks it's very bad pull request to not explain the reason of change.

ivanvc pushed a commit to ivanvc/drone that referenced this pull request Dec 14, 2023
* (DRON-392) cascade deletes on purge
* move cascade purge to build.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants