Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previliged -> Privileged on Repo model #30

Closed
wants to merge 1 commit into from

Conversation

vito
Copy link

@vito vito commented Feb 10, 2014

Probably good to catch this early. I don't see any foundation for database migrations though; any plans there?

@bradrydzewski
Copy link

thanks @vito

I was hoping to use goose, but they don't support sqlite
https://bitbucket.org/liamstask/goose

I do have some simple code that I wrote myself. Added to my local branch. Will push this evening

@vito
Copy link
Author

vito commented Feb 10, 2014

Cool! Didn't know about goose. Shame about the lack of sqlite support, but I'd guess that folks running on sqlite are still in the tinkering stage and wouldn't care too much about migrations.

@bradrydzewski
Copy link

I added a package to handle migration:
https://github.com/drone/drone/blob/master/pkg/database/migrate/migrate.go

Sqlite sure doesn't make it easy to rename a column! Looks like I have to rename the table, create a new table, and migrate the data.

@bradrydzewski bradrydzewski self-assigned this Feb 11, 2014
@vito
Copy link
Author

vito commented Feb 18, 2014

closed by #83

@vito vito closed this Feb 18, 2014
@vito vito deleted the check-your-privilege branch February 18, 2014 16:14
johannesHarness pushed a commit that referenced this pull request Sep 26, 2023
* API integration for Repos listing page

* Add custom branch when creating a repo

* Skeleton for Repository Resource View flow
johannesHarness added a commit that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants