Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine .drone.yml pipeline design #2965

Closed
wants to merge 1 commit into from
Closed

Refine .drone.yml pipeline design #2965

wants to merge 1 commit into from

Conversation

guessi
Copy link

@guessi guessi commented May 9, 2020

Fixed the following problems:

  • Golang version in .drone.jsonnet was pointed to 1.11, but 1.13.0 in .drone.yml

  • Multiple fileds not aligned in .drone.yml, .drone.jsonnet.

Updated

  • May 10, 2020 - remove section of drone-agent and drone-controller
  • Sep 24, 2020 - rebase v1.9.1
  • Sep 24, 2020 - .drone.yml and .drone.jsonnet was removed, ref: 0e4af8d

@CLAassistant
Copy link

CLAassistant commented May 9, 2020

CLA assistant check
All committers have signed the CLA.

@guessi
Copy link
Author

guessi commented May 9, 2020

I'm aware there is another PR for bumping golang version #2936, but this PR is aim to keep .drone.yml and .drone.jsonnet aligned, but not version bumping. So I just bump the golang version to 1.13.0 to keep aligned with .drone.yml (v1.7.0).

@tboerger
Copy link

Controller and agent won't receive any updates, they are deprecated in favor of the runners built on the runners github organization.

Fixed the following problems:

- Golang version in `.drone.jsonnet` was pointed to [1.11](https://github.com/drone/drone/blob/v1.7.0/.drone.jsonnet#L4), but [1.13.0](https://github.com/drone/drone/blob/v1.7.0/.drone.yml#L12) in `.drone.yml`

- Multiple fileds not aligned in `.drone.yml`, `.drone.jsonnet`.

**Updated**

- May 10, 2020 - remove section of `drone-agent` and `drone-controller`
- Sep 24, 2020 - rebase v1.9.1
- Sep 24, 2020 - `.drone.yml` and `.drone.jsonnet` was removed, ref: 0e4af8d
@guessi
Copy link
Author

guessi commented Jan 16, 2021

close, since most update was override by 4a1c639 and removed in 0e4af8d

@guessi guessi closed this Jan 16, 2021
@guessi guessi deleted the drone-jsonnet branch January 16, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants