dot is valid for username #2958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tboerger
reviewed
Apr 30, 2020
| @@ -94,7 +94,7 @@ func (u *User) Validate() error { | |||
| switch { | |||
| case !govalidator.IsByteLength(u.Login, 1, 50): | |||
| return errUsernameLen | |||
| case !govalidator.Matches(u.Login, "^[a-zA-Z0-9_-]+$"): | |||
| case !govalidator.Matches(u.Login, "^[.a-zA-Z0-9_-]+$"): | |||
There was a problem hiding this comment.
Not sure about that, not should the dot be escaped?
There was a problem hiding this comment.
It can't be escaped inside brackets. also i add a test for it and it didn't break any previous cases.
|
@bradrydzewski I guess this would be safe to merge? |
|
@bradrydzewski @tboerger Any update on this? |
|
I'm also waiting on this guys @tboerger @bradrydzewski |
tphoney
approved these changes
Mar 16, 2021
|
Thanks for you patience everyone and special thanks to @okian for the fix and tests. 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Drone doesn't allow (.) in username but thats valid (at least in gitlab)
example: https://gitlab.com/hadi.farnoud