Show an inline error if the wrong password is given when deleting a repo #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! appreciate the help! |
bradrydzewski
added a commit
that referenced
this pull request
Feb 10, 2014
Show an inline error if the wrong password is given when deleting a repo
johannesHarness
added a commit
that referenced
this pull request
Sep 26, 2023
Adds an EOF flag to data chunks to avoid using []byte("EOF") as end (due to potential false positives).
Furthermore, a few cleanups are done:
- Add TODOs for initial git changes
- Add missing file headers
- Fix typo for license (was licence)
- Fix make wire target
johannesHarness
added a commit
that referenced
this pull request
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you entered the wrong password when deleting a repo you'd navigate away from the page and get the
go.crypto/bcrypterror saying that the passwords don't match. Since this is an expected case I've added an inline error, similar to what you'd see when adding a user or repo, to show what went wrong. This could be expanded on later for 500-level errors.