added DRONE_RUNNER_TRUST_ALWAYS env var

[vyckou]

variable added for drone-agent and drone-controller services

[vyckou]

as per #2809 PR comments, added DRONE_RUNNER_TRUST_ALWAYS env var for runners.

This would allow always trust all repositories ignoring their flag in database

[bradrydzewski]

Thanks for this!

We are planning to merge this and a few other pull requests on Tuesday and cut the 1.4 release on Wednesday. You also asked some good design questions in #2809 about environment variable vs flag stored in database. I will respond to those in-depth on Tuesday as well to give you some insight into my thinking.

[bradrydzewski]

hey @vyckou my apologies for the delayed response.

I took some time to evaluate this pull request as well as pull request #2809. I have also taken your feedback into account about pros and cons of direct database updates. We also recently merged a pull request to set the default visibility (see #2826).

Upon further consideration, I think you were correct in your initial suggestion that we should handle this via database update. How do you feel about updating #2809 and re-submitting? The only feedback would be to use the environment variable name DRONE_REPOSITORY_TRUSTED and store this attribute in the Repository struct instead of the Server struct.

I do apologize for the back and forth. Let me know if there is anything I can do to help with #2809. Thanks!

[vyckou]

@bradrydzewski I'm glad, that you have changed your mind 😄
#2830 to review

[bradrydzewski]

closed in favor of #2830 :)