Fixes for Github status reporting #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks Scott! |
bradrydzewski
added a commit
that referenced
this pull request
Feb 10, 2014
Fixes for Github status reporting
johannesHarness
added a commit
that referenced
this pull request
Sep 26, 2023
…Admin User Setup (#28) Adds the basic for harness embedded mode: - Harness dedicated router with custom APIHandler - Inline Space Creation - Client for Account/Org/Project - Bootstrap (Allows for automated creation of admin user and gitness service (used for all platform required ops)) - Inline harness service principal creation - Ignore flag for ACL.
johannesHarness
pushed a commit
that referenced
this pull request
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly there was a tiny syntax error causing
updateGitHubStatus()to always return prematurely which prevented statuses from ever being reported.The second commit defers updating the status rather than explicitly calling it at the end of
execute(). This is a personal preference so let me know if you'd like to change it. Due to some weirdness in my dev environment I was seeing builds fail much earlier so it seems to make sense that an error in Drone is a valid reason to report a build error on the pull request (or at least call out that it couldn't be built).