Add id column in migrations table for MySQL Group Replication #2772
Conversation
| @@ -186,6 +186,7 @@ func selectCompleted(db *sql.DB) (map[string]struct{}, error) { | |||
|
|
|||
There was a problem hiding this comment.
this file is automatically generated and should not be manually updated. Otherwise the next time we generate this file your changes will be lost. You need to send a pull request to update the generator, and then you need to regenerate this file using go generate
There was a problem hiding this comment.
sorry I don't know the file where should I modify.
There was a problem hiding this comment.
| @@ -186,6 +186,7 @@ func selectCompleted(db *sql.DB) (map[string]struct{}, error) { | |||
|
|
|||
| var migrationTableCreate = ` | |||
| CREATE TABLE IF NOT EXISTS migrations ( | |||
| id INTEGER PRIMARY KEY AUTO_INCREMENT, | |||
| name VARCHAR(255) | |||
There was a problem hiding this comment.
If a primary key is required could we just remove the unique constraint from the name column, and use a primary key constraint instead?
CREATE TABLE IF NOT EXISTS migrations (
name VARCHAR(255)
-,UNIQUE(name)
+,PRIMARY KEY(name)
)There was a problem hiding this comment.
yes. I think no need id if name is unique.
| @@ -176,6 +176,7 @@ github.com/hashicorp/go-multierror v1.0.0 h1:iVjPR7a6H0tWELX5NxNe7bYopibicUzc7uP | |||
| github.com/hashicorp/go-multierror v1.0.0/go.mod h1:dHtQlpGsu+cZNNAkkCN/P3hoUDHhCYQXV3UM06sGGrk= | |||
There was a problem hiding this comment.
please exclude this file from the pull request
rluisr
force-pushed
the
fix/migrations_pk
branch
2 times, most recently
from
c934da2
to
a3d68ca
Compare
|
I recreate PR for excluding go.sum when this PR is merged. |
Need PK each table on MySQL Group Replication.
Run drone and add id primary key, It’s worked.