Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post installation and pre removal script for debian package. #26

Merged
merged 1 commit into from
Feb 10, 2014

Conversation

fudanchii
Copy link

Current debian package wont stop droned when uninstalled.
Add maintainer script to do this.
Also auto-start droned when installed from deb, safe assuming that other real web server may already occupy port 80, set 8080 as default port to listen to.

@fudanchii
Copy link
Author

Hey @bradrydzewski
should I update the README for this? or maybe you want to keep using port 80 as default?
It's actually fine by me, just want to play safe here. ;)

@bradrydzewski
Copy link

@fudanchii another awesome patch! thanks!

Let's keep port :80 as the default for upstart. I'm guessing that most developers downloading and installing with the .deb file will probably run on :80. But if it turns out they prefer :8080 then we can change it back :)

Thanks again!

@fudanchii
Copy link
Author

Sure, sounds great to me.
I updated the commit.

Thanks!

bradrydzewski added a commit that referenced this pull request Feb 10, 2014
Add post installation and pre removal script for debian package.
@bradrydzewski bradrydzewski merged commit a1699fb into harness:master Feb 10, 2014
@vespakoen
Copy link

Putting it on port 80 is what made me uninstall it a couple of weeks ago.
A mention in the docs how to change it would be nice I guess.

Also, I think most people running linux / a server will already have apache / nginx whatever running on port 80, using a different port is (IMO) the way to go.

Just my 2 cents ;)

@notandy
Copy link

notandy commented Mar 3, 2014

👍
gently pointing to my pull request #98

You can change it in /etc/defaults/drone, an example is provided

@fudanchii fudanchii deleted the default-conf branch April 23, 2014 17:04
johannesHarness added a commit that referenced this pull request Sep 26, 2023
Simplify the router code by removing the translator. Now that we have Api/Git/WebHandler interfaces, they can be wrapped in handlers to do any custom request translation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants