Clean up status codes. #2479
Closed
Clean up status codes. #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
why?? |
|
I think this is quite the opposite of what you want to do in Go. The constants are way more descriptive and reference the same numbers you've just replaced them with. |
|
Well, i'm new to go! |
|
@Alireza-Ta Thanks for taking the time to contribute nevertheless! I hope you learned something, keep the PRs coming. 👍 |
|
Oh wait. You actually want to use the constants. I'm not really sure how important that is to @bradrydzewski. 🤔 |
|
No, I had also been confused. Look at his first commit: 8183907 |
|
@metalmatze You said using consts is better than just plain numbers because of that I changed it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey
Just change all http status codes to numerical format in
serverdirectory.