Add ability to restart build of any state #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
server/build.go
Outdated
| case model.StatusPending, | ||
| model.StatusRunning, | ||
| model.StatusDeclined, | ||
| model.StatusBlocked, |
There was a problem hiding this comment.
I think we might want to keep Declined and Blocked since this typically indicates a build has a security-related change that needs manual evaluation. But otherwise, we should be able to remove all others.
|
@bradrydzewski, PR updated: error on StatusRunning and StatusBlocked retrieved. |
tboerger
approved these changes
Apr 6, 2018
appleboy
approved these changes
Apr 7, 2018
Closed
|
Really keen to get hold of this feature. - Any chance of a release? |
|
This will be part of v0.9 |
|
@tboerger: Do you know when v0.9 will be coming? We're still very keen to get hold of this feature. |
|
@daniel-ac-martin as usual, when it's done :P but to be serious I can't answer that. |
|
It's great this commit made its way to v0.8.6, thanks! |
|
True, totally forgot this commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build in any state can be restarted.
If it was an error - external environment (dependencies) can changes till now.
If build already running/pending - it is not a problem to schedule new build.