Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bitbucket integration #232

Merged

Conversation

asabil
Copy link

@asabil asabil commented Mar 28, 2014

No description provided.

@bradrydzewski
Copy link

thanks @asabil

can you please slightly refactor the code, based on my initial commit:
https://github.com/bradrydzewski/drone/blob/bitbucket/pkg/handler/bitbucket.go

the bitbucket handlers should be in a struct called BitbucketHandler and all contained in a single bitbucket.go file. We will be refactoring the github code to be contained in a github.go file as well.

@bradrydzewski
Copy link

Also we'll need test coverage. You can see the GitHub tests as reference:
https://github.com/drone/drone/blob/master/pkg/handler/testing/github_test.go

Sorry, I should have been more specific in the Bitbucket thread what still needed to be done

@asabil
Copy link
Author

asabil commented Mar 28, 2014

No worries, i will try to make these changes as soon as possible. My fault really didn't check if there was an issue already open

@bradrydzewski
Copy link

ah, got it, for some reason I thought that "PUT" worked ... we've been using it for 1+ years and it has been broken this whole time!

bradrydzewski added a commit that referenced this pull request Mar 28, 2014
@bradrydzewski bradrydzewski merged commit e2831f3 into harness:master Mar 28, 2014
@bradrydzewski
Copy link

oops, I meant to merge your change to go-bitbucket ... no worries, let's still make the proposed changes if you don't mind.

@bradrydzewski bradrydzewski mentioned this pull request Mar 28, 2014
@bradrydzewski
Copy link

fyi, I also added my notes to issue #2 so that we could track progress. I'll close issue #2 and update the documentation once the above changes are made. Thanks again!

@asabil asabil deleted the feature/bitbucket-integration branch March 31, 2014 08:15
@bradrydzewski bradrydzewski added this to the v0.2 milestone Apr 1, 2014
@bradrydzewski bradrydzewski modified the milestones: v0.2, v0.3 Apr 10, 2014
fd added a commit to fd/drone that referenced this pull request Apr 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants