Allow setting MinTime for keepalive enforcement on server #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows setting agent keepalive Time at value < 5m
tboerger
reviewed
Jan 9, 2018
cmd/drone-server/server.go
Outdated
| cli.DurationFlag{ | ||
| EnvVar: "DRONE_KEEPALIVE_MIN_TIME", | ||
| Name: "keepalive-min-time", | ||
| Usage: "coding skip ssl verification", |
tboerger
approved these changes
Jan 27, 2018
appleboy
approved these changes
Jan 28, 2018
tonglil
approved these changes
Jan 30, 2018
tonglil
reviewed
Jan 30, 2018
| cli.DurationFlag{ | ||
| EnvVar: "DRONE_KEEPALIVE_MIN_TIME", | ||
| Name: "keepalive-min-time", | ||
| Usage: "server-side enforcement policy on the minimum amount of time a client should wait before sending a keepalive ping.", |
There was a problem hiding this comment.
do you mind dropping the period at the end of this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows setting agent keepalive Time at value < 5m