Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swagger definition #2252

Closed
wants to merge 2 commits into from

Conversation

mavimo
Copy link

@mavimo mavimo commented Oct 31, 2017

Issue

Hi, I see there are a swagger definition in server/swagger/files that I suppose is manually generated; but there is a go:generate directive to automatically generate it.
Generated file is out of sync with yaml definition and there are some issue on yaml file; you can check by C&P it into Swagger editor.

This PR will fix definition error in YAML file and add some more definitions for Swagger generated code.

You can test it with:

rm -rf server/swagger/files/swagger.json
go genrate -run swagger ./...
swagger validate server/swagger/files/swagger.json
swagger serve server/swagger/files/swagger.json

ToDo

  • Fix swagger definition
  • Add some more entry into swagger definition

Discussion

I'm not sure why we are going to add a custom code in a package just to use annotation on it, maybe we should move annotation where we add the real code, than use drone/swagger package only for swagger:parameters?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants