Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urgent fix for changed auth behavior on Gitea #2241

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Urgent fix for changed auth behavior on Gitea #2241

merged 1 commit into from
Oct 13, 2017

Conversation

tboerger
Copy link

Within the PR go-gitea/gitea#2184 on Gitea the
project dropped the standard behavior to use x-auth-basic personal
access token. So we should use a proper username and the token from now
on to support Gitea >= 1.2.0. Since this driver anyway only supports
Gitea >= 1.2.0 this won't be a breaking change on Drone side, the only
breaking change is on side of Gitea!

@metalmatze
Copy link

And I was wondering what changed in drone 0.8 that it didn't work anymore. 😕
But I was running 1.2 RCs and apparently that was the problem.

Within the PR go-gitea/gitea#2184 on Gitea the
project dropped the standard behavior to use x-auth-basic personal
access token. So we should use a proper username and the token from now
on to support Gitea >= 1.2.0. Since this driver anyway only supports
Gitea >= 1.2.0 this won't be a breaking change on Drone side, the only
breaking change is on side of Gitea!
@bradrydzewski bradrydzewski merged commit 578e884 into harness:master Oct 13, 2017
@tboerger tboerger deleted the fix-gitea branch October 13, 2017 15:20
@ptman
Copy link

ptman commented Oct 31, 2017

When is this going to be part of a release?

@tboerger
Copy link
Author

tboerger commented Nov 2, 2017

With the next upcoming tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants