Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail pending on startup #213

Merged
merged 4 commits into from
Apr 1, 2014

Conversation

mnutt
Copy link

@mnutt mnutt commented Mar 24, 2014

When drone starts up, any builds in the 'Pending' or 'Started' state should be marked as failed, since they will never succeed.

@bradrydzewski
Copy link

Thanks for this! I would like propose one minor change. Let's combine the update statements to update both started and pending with a single command, using the IN operator:

UPDATE builds
SET status = 'Failure'
WHERE status IN ('Started', 'Pending')
UPDATE commits
SET status = 'Failure'
WHERE status IN ('Started', 'Pending')

@bradrydzewski
Copy link

thanks for the changes! am I good to merge?

@mnutt
Copy link
Author

mnutt commented Apr 1, 2014

Yeah, it should be fine to merge.

bradrydzewski added a commit that referenced this pull request Apr 1, 2014
@bradrydzewski bradrydzewski merged commit dd46fa9 into harness:master Apr 1, 2014
@bradrydzewski bradrydzewski added this to the v0.2 milestone Apr 1, 2014
@bradrydzewski
Copy link

thanks again for this, works like a charm :)

@bradrydzewski bradrydzewski modified the milestones: v0.3, v0.2 Apr 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants