Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Add building doc and Makefile #2103

Closed
wants to merge 2 commits into from
Closed

Conversation

flaccid
Copy link

@flaccid flaccid commented Jul 10, 2017

The .drone.sh requires the closed source enterprise repo and is intended for CI.

Basic documentation on building Drone CI is missing. Can we add in some doc and also make it easier to build by supplying a Makefile?

From here, it would be good to also look at dependency management. Currently I've kept it simple by installing the deps manually.

@CLAassistant
Copy link

CLAassistant commented Jul 10, 2017

CLA assistant check
All committers have signed the CLA.

@appleboy
Copy link

See #2040

@flaccid
Copy link
Author

flaccid commented Jul 10, 2017

Thanks for the link. Certainly a historic Makefile there. The new one focuses on being a shortcut/helper to standard commands.

@tboerger
Copy link

👎 we have went away from makefile. And for the docs, we got a repo where this can get documented

@flaccid
Copy link
Author

flaccid commented Jul 10, 2017

@tboerger usability is important. I see two docs repositories 👎 .
https://github.com/drone/docs
https://github.com/drone/docs.drone.io

Docs sites:

Mileage varies, but steps for building is missing from either. Are the docs to be consolidated?

@tboerger
Copy link

As you can see on the commits it's the docs repo. docs.drone.io is the documentation for current version, readme.drone.io will be dropped, it have been the documentation for older drone versions.

@donny-dont
Copy link

I don't know that the docs site should have info on how to build drone. The official way is to use the docker images not to build with source. Building from source should be present but in the repo itself in my opinion.

@bradrydzewski
Copy link

I think I am partial to adding something to docs.drone.io. I have been using docker's tutorials for building docker from source, which were quite helpful. They were a bit more verbose and included more examples than something you would find in a README

In the short term perhaps we add a BUILDFILE to the repository that describes the current build process for people that want to compile drone locally.

#
# install dependencies
#

go get -u github.com/drone/drone-ui/dist
go get -u golang.org/x/net/context
go get -u golang.org/x/net/context/ctxhttp
go get -u github.com/golang/protobuf/proto
go get -u github.com/golang/protobuf/protoc-gen-go

#
# install binaries to $GOPATH/bin
#

go install github.com/drone/drone/cmd/drone-agent
go install github.com/drone/drone/cmd/drone-server

@bradrydzewski bradrydzewski mentioned this pull request Jul 25, 2017
@bradrydzewski
Copy link

drone repositories now using BUILDING files

bot2-harness pushed a commit that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants