Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the cc.xml CCMenu include a Project entry per Branch #2012

Closed
wants to merge 3 commits into from
Closed

Make the cc.xml CCMenu include a Project entry per Branch #2012

wants to merge 3 commits into from

Conversation

donatj
Copy link

@donatj donatj commented Apr 27, 2017

CCMenu xml responses are able to include multiple projects. We often have multiple branches running at the same time and right now we only get one ccmenu status back.

This leaves the existing CCProject entry and adds additional Project rows for the individual branches.

It'd be nice for me to be able to just track our dev and master branches separately, so I've altered the cc.go to allow this.

I have not yet altered the tests, I wanted to make sure there was actual interest in doing this first, but I'd certainly be happy to.

@donatj
Copy link
Author

donatj commented Aug 1, 2017

I would like to see this one considered.

I corrected the major complaints about breaking backwards compatibility by making the first CCProject entry the same as the existing entry and subsequent entries individual branches. I think that should quell fears.

@bradrydzewski
Copy link

bradrydzewski commented Aug 1, 2017

Unfortunately I can't see my prior comments, and I apologize if they were vague, but in order to merge the behavior should be opt-in. This means we should preserve the current behavior and only display more branches when specified by a URL parameter.

For example, if ?branch=master,develop

This follows the same behavior as the badges are customized with URL parameters.

@bradrydzewski
Copy link

bradrydzewski commented Aug 1, 2017

actually, we may end up adding multiple projects to a single repository [1] which could impact this feature. Should probably think through the design implications first. I would hate to merge this and then have to remove it in a future release.

[1] #1021 (comment)

@bradrydzewski
Copy link

closing in favor of v1.0 triggers

bot2-harness pushed a commit that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants