implement jsonrpc2 agent behind feature flag #1954
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be enabled by passing the DRONE_CANARY=true environment variable to the agent and the server. This will use a jsonrpc2 protocol for agent to server communication and a simplified queue and log manager, replacing the former mq package.
The purpose of this chance is improved scalability and reliability. The agents are better equipped to recover from failures and less likely to end up in an inconsistent state. This also introduces a new yaml parser and compiler, which should enable compatibility with other yaml files (compatibility with gitlab, bitbucket pipelines, travis, etc) and with multiple runners (kubernetes, docker, etc)
This alternate implementation has a number of issues and missing features.
drone_
environment variables still existThis alternate implementation does contain breaking changes:
The following items need more testing:
Please note this patch does not impact existing installations unless you set the DRONE_CANARY flag. If you do not set this flag this patch will not impact your existing installation.