Expose the parent build number as DRONE_PARENT_BUILD_NUMBER #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe this should be called |
|
agreed, |
bradrydzewski
requested changes
Feb 11, 2017
agent/agent.go
Outdated
| @@ -312,6 +312,7 @@ func toEnv(w *model.Work) map[string]string { | |||
| } | |||
| if w.Build.Event == model.EventDeploy { | |||
There was a problem hiding this comment.
this value can be set for all event types, so it can be moved outside this if block
agent/agent.go
Outdated
| @@ -312,6 +312,7 @@ func toEnv(w *model.Work) map[string]string { | |||
| } | |||
| if w.Build.Event == model.EventDeploy { | |||
| envs["DRONE_DEPLOY_TO"] = w.Build.Deploy | |||
| envs["DRONE_DEPLOY_FROM"] = fmt.Sprintf("%d", w.Build.Parent) | |||
There was a problem hiding this comment.
rename to DRONE_PARENT_BUILD_NUMBER as suggested
robertstettner
changed the title
|
@bradrydzewski Changes have been implemented, this is ready to go 👍 |
|
gentle ping... |
|
@robertstettner can you fix pr ? |
This was referenced May 11, 2017
|
@vtolstov This was fixed a long time ago... delayed for merge for an unknown reason, and now the PR has been "stolen" by another. Quite sad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this so that I could use the artifacts that I put on S3 with the build number, in my deployments (so that I wouldn't have to build them again).