Remove size limit #1929
Remove size limit #1929
Conversation
|
The size limit is necessary because sqlite cannot handle more than 999 parameters. This limitation is discussed at http:https://www.sqlite.org/limits.html Therefore |
|
Note that I'm fine with increasing for Postgres and MySQL, but we need to keep this limit in place for installations using SQLite. |
|
I thought the last commit I had (based on a past comment ) only made the increase applicable to non SQLite but I'll double check. |
|
@bradrydzewski after looking at it, I have it so that it will increase the limit for mySQL (toList) and postgres but not SQLite (toList makes the check). Let me know if I'm missing something :) |
store/datastore/utils.go
Outdated
| var size = len(listof) | ||
| if size > 999 { | ||
| switch { | ||
| case meddler.Default == meddler.SQLite && size > 999: |
There was a problem hiding this comment.
I don't think this change is required because toListPostgres should only be invoked when meddler.Default == meddler. PostgreSQL. If you are seeing otherwise in the code let me know
There was a problem hiding this comment.
You're right it does get covered since it's only in the PostgreSQL portion. I updated to not check again.
|
@josmo you are correct, looks like you've got your bases covered. I did add one last comment |
|
@bradrydzewski updated for your comment so it should be ready :) |
temp fix for #1783 and until #1793 or the alternative get pulled in. This should deal with larger number of repos on non SQLite dbs