Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable all webhook events by default for Gogs remote #1895

Merged
merged 1 commit into from
Jan 3, 2017
Merged

Enable all webhook events by default for Gogs remote #1895

merged 1 commit into from
Jan 3, 2017

Conversation

mjwwit
Copy link

@mjwwit mjwwit commented Jan 3, 2017

This PR enables all webhook events by default for Gogs and Gitea remotes. Since Drone now has support for all of these events, it makes sense to enable them in the webhook config.

This will save users the hassle of enabling these hooks every time they activate a repository in Drone.

@bradrydzewski
Copy link

bradrydzewski commented Jan 3, 2017

I believe create was explicitly excluded. In github this would trigger hooks for branch and tag creation, which would double-trigger for branch pushes and tag pushes. What is the behavior in Gogs?

@mjwwit
Copy link
Author

mjwwit commented Jan 3, 2017

It will trigger for the creation of branches as well, but the Drone create hook parser will ignore everything that isn't a tag creation.

@bradrydzewski
Copy link

ok awesome, thanks!

@bradrydzewski bradrydzewski merged commit c8a97d0 into harness:master Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants