adding pagination of repositories on bitbucketserver

[thiago]

Fix issue #1776

[CLAassistant]

All committers have signed the CLA.

[bradrydzewski]

while in the code, some minor things that could be improved:

-log.Debug(fmt.Printf("repoResponse: %+v\n", repoResponse))
+log.Debugf("repoResponse: %+v", repoResponse)

[josmo]

LGTM :) Thanks @thiago

[appleboy]

LGTM! 👍

[josmo]

Btw not sure on you're end but making the limit 400 instead of 1000 may make it a little more responsive. I haven't tried it but might be worth checking out

[thiago]

it does not make it slower?

[bradrydzewski]

Btw not sure on you're end but making the limit 400 instead of 1000 may make it a little more responsive. I haven't tried it but might be worth checking out

I'll merge and this can be handled in a follow-up pull request. The current implementation could probably be improved a bit more to more closely mirror the existing bitbucket implementation, but this can be done separately:

func (c *Client) ListRepos(account string, opts *ListOpts) (*RepoResp, error) {
    out := new(RepoResp)
    uri := fmt.Sprintf(pathRepos, c.base, account, opts.Encode())
    err := c.do(uri, get, nil, out)
    return out, err
}

func (c *Client) ListReposAll(account string) ([]*Repo, error) {
    var page = 1
    var repos []*Repo

    for {
        resp, err := c.ListRepos(account, &ListOpts{Page: page, PageLen: 100})
        if err != nil {
            return repos, err
        }
        repos = append(repos, resp.Values...)
        if len(resp.Next) == 0 {
            break
        }
        page = resp.Page + 1
    }
    return repos, nil
}