Integrated gogs webhook deletion #1752
Conversation
|
awesome, thanks for working on this one! I think we might need to mirror this after the GitHub hook removal as well. Notice we have logic to find the matching hook: the matching hooks function parses the URL to remove the token from the url query string. Otherwise it won't properly match the link that is passed in EDIT: I'm looking at your implementation and it does look like the |
|
I will do it the same like GitHub. And than I have to fix the tests, looks like there have been something broken because of the client update. |
|
@bradrydzewski I don't get the tests running correctly but at least the deletion of webhooks works now. Maybe you can do a small addition afterwards to get the tests correct since you are deeper in it? |
|
what issues are you seeing w/ the unit tests? maybe I can help |
| @@ -255,3 +270,25 @@ func (c *client) newClientToken(token string) *gogs.Client { | |||
| } | |||
| return client | |||
| } | |||
|
|
|||
| // helper function to return matching hook. | |||
| func matchingHooks(hooks []*gogs.Hook, rawurl string) *gogs.Hook { | |||
There was a problem hiding this comment.
can you add some unit tests for this function similar to
https://github.com/drone/drone/blob/master/remote/bitbucket/bitbucket_test.go#L233
|
@tboerger could you please take a look at this again? |
A little bit busy at the moment, but I try to come back ASAP. |
|
any progress in this pr? |
|
Sorry, I forgot about this PR. |
|
does this needs to be merged before gitea driver? |
|
Closing this in favor of go-scm |
Fixes #1603