Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization/Team secrets #1737

Merged
merged 10 commits into from
Aug 10, 2016
Merged

Organization/Team secrets #1737

merged 10 commits into from
Aug 10, 2016

Conversation

tboerger
Copy link

I just want to open this PR even if i'm still not done with it to show the progress since there are various people interested in that feature.

@tboerger tboerger changed the title [WIP] Organization/Team secrets Organization/Team secrets Jul 31, 2016
DeleteTeamSecret(*model.TeamSecret) error

// GetMergedSecretList gets a list of repo and team secrets
GetMergedSecretList(*model.Repo) ([]*model.Secret, error)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can actually merge the two lists in store instead of datastore. That way, if we have multiple implementations of datastores, we don't need to duplicate the merge logic

@bradrydzewski
Copy link

awesome work! added a few minor comments related to the merge function and moving that up a level. But otherwise looks awesome and almost ready to merge!

@tboerger
Copy link
Author

tboerger commented Aug 1, 2016

awesome work! added a few minor comments related to the merge function and moving that up a level. But otherwise looks awesome and almost ready to merge!

Thanks, I already realized that I need to write a middleware to check org admin rights. I will address the other comments.

@donny-dont
Copy link

@tboerger should that be a requirement? Or just Drone admin?

@tboerger
Copy link
Author

tboerger commented Aug 1, 2016

@donny-dont an org admin should be able to add org secrets :). Global secrets should be done only by drone admins.

@tboerger
Copy link
Author

tboerger commented Aug 2, 2016

@bradrydzewski IMHO this should work now.

@bradrydzewski
Copy link

really sorry for the delay but I sort of have a good excuse :)

merging now!

@bradrydzewski bradrydzewski merged commit abaa02e into harness:master Aug 10, 2016
@tboerger tboerger deleted the feature/org-secrets branch August 10, 2016 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants