Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Phabricator remote integration #1499

Closed
wants to merge 1 commit into from
Closed

[WIP] Phabricator remote integration #1499

wants to merge 1 commit into from

Conversation

tboerger
Copy link

This is currently work in progress. I have started to integrate phabricator as a remote into drone. The authentication already works, but now we need to find ways to add the other missing parts as well.

The client parts are taken from the Gitlab client.

@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@tboerger
Copy link
Author

It still doesn;t really work is much more complicated. As nobody requested that I will close that for now.

@tboerger tboerger closed this Apr 25, 2016
@tboerger tboerger deleted the feature/phabricator branch September 12, 2017 07:17
@tlwt
Copy link

tlwt commented Jan 30, 2018

is there any suggested way on working with phabricator? I really appreciate the drone as well as phabricator and think a combination of both would be great!

@tboerger
Copy link
Author

An phabricator remote driver must implement the interface defined at https://github.com/drone/drone/blob/master/remote/remote.go.

I don't know how open brad is for new remote drivers or if he wants to enable an external service implementation instead of this.

@tlwt
Copy link

tlwt commented Jan 30, 2018

If you mean by external services that you can create some random web hook and drone kicks off - that would be great as well, I suppose.

@zicklag
Copy link

zicklag commented Mar 22, 2018

I would really like to be able to integrate Phabricator with Drone somehow.

@bradrydzewski
Copy link

bradrydzewski commented Mar 22, 2018

the steps required for phabricator integration are

  1. add phabricator oauth login provider to https://github.com/drone/go-login
  2. add phabricator provider to https://github.com/drone/go-scm
  3. wait until 0.9 when go-login and go-scm are integrated into drone core
  4. profit

no plans to implement on my end, but I would happily accept pull requests to the above two repositories. The login code should be straightforward, since it seems to have already been implemented by @tboerger in this closed pull request and just needs to be ported over.

@zicklag
Copy link

zicklag commented Mar 23, 2018

Cool, I might look into that after 0.9 comes out, then. 🙂

@mavimo
Copy link

mavimo commented Mar 26, 2018

@bradrydzewski
Copy link

oops, it is https://github.com/drone/go-scm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants