Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add master build list endpoint for wall #1460

Closed
wants to merge 1 commit into from

Conversation

scottferg
Copy link

@bradrydzewski this adds a top level build list (similar to what we added to v3) that is necessary for drone-wall to operate.

@CLAassistant
Copy link

CLA assistant check
All committers have accepted the CLA.

@bradrydzewski
Copy link

@scottferg I think you can use the existing /api/user/feed endpoint for this. It should be the same thing we have in 0.3 but altered for use with 0.4

you'll just need to make sure the token used to query the feed is generated from an account that has access to all your repos (ideally an organization admin).

the only reason I suggest this (/api/user/feed) is that a larger drone installation may be used across multiple github enterprise organization, and have multiple drone walls with the repos specific to their organization. But let me know your thoughts!

@scottferg
Copy link
Author

Yup! Totally can. Serves me right for not reading the docs.

@scottferg scottferg closed this Feb 5, 2016
@bradrydzewski
Copy link

actually, it isn't in the docs :)

... so you can blame me

@bradrydzewski
Copy link

for reference, the reason this wasn't documented was I didn't want to advertise the endpoint until it was benchmarked in case it needed to be removed or tweaked. The benchmark was positive (you can see at #1234) so you should be good to rely on this endpoint going forward.

@scottferg
Copy link
Author

Ha cool. I don't feel like as big of an idiot. This will make getting the wall up to snuff much easier either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants